-
Notifications
You must be signed in to change notification settings - Fork 1.7k
config: implement storage inheritance option #10396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e413143
to
739e32d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic seems good to me. But I found a nitpick. So, I still leave a comment now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my side, it looks good.
@niedbalski thank you. would you pls cleanup the commit history ? |
d1f8e74
to
29a9279
Compare
29a9279
to
e95a1c8
Compare
Adds storage inheritance logic allowing input instances to inherit global storage configuration.
Example configuration with global storage inheritance:
Expected behavior:
Example configuration without global storage:
Expected behavior: