backport 31a8163, b41742e, and 7130d74 #10344
Open
+111
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoksc
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
leonardo-albertovich
approved these changes
May 16, 2025
stoksc
changed the title
|
This backport is stale now. Once my commit is approved and merged in master I will redo this backport. I would like to wait until then to prevent any wasted effort. |
stoksc
force-pushed
the
stoksc/backport-invalid-input-property
branch
from
4ccdcf9 to
8486479
Compare
This change makes Fluent Bit fail to start when a configuration includes an invalid processor (one that doesn't exist or fails to initialize). Previously, Fluent Bit would log an error but continue starting up, potentially masking configuration issues. - Add early exit conditions when a processor plugin doesn't exist - Add early exit conditions when a processor plugin fails to initialize - Improve error messages to be more descriptive Part of fluent#10305
… handling This test verifies Fluent Bit's behavior when configured with a non-existent processor. It checks that Fluent Bit properly fails to start and reports a relevant error message. Part of fluent#10305
After this change, when a plugin configuration contains an invalid property, `configure_plugins_type` returns an error which ultimately crashes fluentbit, instead of only printing an error log and continuing on. The change also fixes a small issue where `name` was printed by `flb_error` after it was freed. To properly test this change and get the test to pass with `-DSANITIZE_ADDRESS=On` on all platforms, I had to update `configure_plugins_type` to free objects that it fails to instantiate. Signed-off-by: Bradley Laney <[email protected]>
stoksc
force-pushed
the
stoksc/backport-invalid-input-property
branch
from
8486479 to
915d567
Compare
|
@leonardo-albertovich I've updated this backport if you still want it. If not let me know and I'll close it and more on, either way is fine. |
stoksc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #10305 and #10296.
I backported @niedbalski's change first because my change is based on it in a small way and, with the conflicts, my choices were to either:
goto errorin my change is missed since it wouldn't conflict anymore.both of which felt worse than just picking his change first.
His commits had no conflicts except that I dropped two small chunks from his change in flb_processor.c that updated log messages that do not exist in 3.2.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.