Skip to content

refactor(ui): improve index #2669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 16, 2024
Merged

refactor(ui): improve index #2669

merged 2 commits into from
Jan 16, 2024

Conversation

erka
Copy link
Contributor

@erka erka commented Jan 16, 2024

  • update index.dev.html with new command to run ui in dev mode
  • added noscript message in index.html
  • add head tag to index.html

@erka
refactor(ui): improve index
b862f5b 
- update index.dev.html with new command to run ui in dev mode
- added noscript message in index.html
- add head tag to index.html
@erka erka requested a review from a team as a code owner January 16, 2024 13:45
@codecov Codecov
Copy link

codecov bot commented Jan 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (30faff5) 73.02% compared to head (b862f5b) 73.02%.

❗ Current head b862f5b differs from pull request most recent head b1d3331. Consider uploading reports for the commit b1d3331 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2669   +/-   ##
=======================================
  Coverage   73.02%   73.02%           
=======================================
  Files          85       85           
  Lines        8326     8326           
=======================================
  Hits         6080     6080           
  Misses       1869     1869           
  Partials      377      377

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

markphelps
markphelps reviewed Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor wording change requested. looks good! ty

@erka @markphelps
Update ui/index.html
b1d3331 
Co-authored-by: Mark Phelps <[email protected]>
markphelps
markphelps approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@markphelps markphelps added the automerge Used by Kodiak bot to automerge PRs label Jan 16, 2024
@kodiakhq kodiakhq bot merged commit 323f0f3 into flipt-io:main Jan 16, 2024
@erka erka deleted the ui-index-noscript branch January 16, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markphelps markphelps markphelps approved these changes

Assignees
No one assigned
Labels
automerge Used by Kodiak bot to automerge PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erka @markphelps