Skip to content

refactor(ui): improve Yup usage #2647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 13, 2024
Merged

refactor(ui): improve Yup usage #2647

merged 3 commits into from
Jan 13, 2024

Conversation

erka
Copy link
Contributor

@erka erka commented Jan 12, 2024

  • move creation of validation schemas out of render blocks
  • use a new validation schema for console context as it isn't a any json object but map[string]string
  • update Yup to new major version

@erka
refactor(ui): improve Yup usage
393a621 
- move creation of validation schemas out of render blocks
- use a new validation schema for console context as it isn't a any json object but map[string]string
- update Yup to new major version
@erka erka requested a review from a team as a code owner January 12, 2024 15:49
@codecov Codecov
Copy link

codecov bot commented Jan 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e2a4ecb) 73.02% compared to head (2066e07) 73.02%.
Report is 1 commits behind head on main.

❗ Current head 2066e07 differs from pull request most recent head 76175de. Consider uploading reports for the commit 76175de to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2647   +/-   ##
=======================================
  Coverage   73.02%   73.02%           
=======================================
  Files          85       85           
  Lines        8326     8326           
=======================================
  Hits         6080     6080           
  Misses       1869     1869           
  Partials      377      377

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

markphelps
markphelps approved these changes Jan 13, 2024
View reviewed changes
Copy link
Collaborator

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@markphelps markphelps added the automerge Used by Kodiak bot to automerge PRs label Jan 13, 2024
@kodiakhq kodiakhq bot merged commit be60549 into flipt-io:main Jan 13, 2024
@erka erka deleted the ui-yup branch January 13, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markphelps markphelps markphelps approved these changes

Assignees
No one assigned
Labels
automerge Used by Kodiak bot to automerge PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erka @markphelps