Use DataModel analysis #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
passhley
requested changes
Nov 25, 2023
passhley
approved these changes
Nov 30, 2023
vocksel
added a commit
that referenced
this pull request
Dec 1, 2023
# Problem Attempting to use the `flipbook` variable to reference our types in the past has resulted in those types not being recognized by luau-lsp. That problem is now fixed with #227, so now we're free to use shorter paths # Solution This PR updates most `script.Parent` paths to use the `flipbook` variable (and define it as needed) so that all paths are absolute. # Checklist - [ ] Ran `./bin/test.sh` locally before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, using
tests.project.jsongives better analysis thatdev.project.json. Seems like this is because the former will mount flipbook to the DataModel.This PR updates our analysis to generate sourcemaps from
tests.project.json, and also fixes up the resulting type errors from this change