Skip to content

CriticMarkup LaTeX output uses \sout and \underline #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost opened this issue May 14, 2018 · 4 comments
Closed

CriticMarkup LaTeX output uses \sout and \underline #121

ghost opened this issue May 14, 2018 · 4 comments

Comments

@ghost
Copy link

ghost commented May 14, 2018

Since you are using the soul package, it would be a better idea to use its \ul{...} command for addition marking instead of \underline{...}, as the latter does not flow text well, putting the underlined text into a float. Additionally you are using the \sout{...} command, which doesn't work with soul, the \st{...} command should be used instead.

@fletcher
Copy link
Owner

Do you have a good example where things are broken?

@ghost
Copy link
Author

ghost commented May 14, 2018

It looks like the \sout problem is okay; I was using a slightly modified mmd6-memoir-packages file that lacked the ulem package. The underlining issue can be seen with the following example. Note the \ul command produces a better result across multiple lines:

\input{mmd6-article-leader}
\def\mytitle{Test}
\input{mmd6-article-begin}

Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis \underline{nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur}. Excepteur sint \sout{occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit }anim id est laborum.

Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis \ul{nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur}. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.

\input{mmd6-article-footer}
\end{document}

@fletcher
Copy link
Owner

fletcher commented May 14, 2018

Will stick with default \underline since not everyone uses soul, but will swap the two when soul is activated.

Thanks!

@ghost
Copy link
Author

ghost commented May 14, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant