-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to test-go CI job #27916
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #27916 +/- ##
==========================================
+ Coverage 63.67% 63.88% +0.21%
==========================================
Files 1775 1772 -3
Lines 169498 169470 -28
Branches 4947 4834 -113
==========================================
+ Hits 107928 108267 +339
+ Misses 53137 52666 -471
- Partials 8433 8537 +104
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# Conflicts: # .github/workflows/test-go.yaml # Makefile
georgekarrv
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes several improvements to test-go CI job
scripts
suitefast
suite that does not have out-of-process dependencies, which completes in ~1.5 minutescore
tomain
test suite to be consistent with Makefile. It is the default bucket for tests.test-schema
andmock
prerequisites fortest-go
since they are not needed and just take up time.test-schema
run to one of the test suites just in case.Unfortunately,
fleetctl
is still the bottleneck and needs to be refactored. New issue filed: #27927Before
After