-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCIM + host integration #27880
Draft
getvictor
wants to merge
64
commits into
main
Choose a base branch
from
victor/27284-scim-host-integration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
SCIM + host integration #27880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # server/datastore/mysql/schema.sql
# Conflicts: # ee/server/scim/scim.go # ee/server/scim/users.go # server/datastore/mysql/scim.go # server/datastore/mysql/scim_test.go # server/fleet/datastore.go # server/fleet/scim.go # server/mock/datastore_mock.go
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## victor/27287-scim-tests #27880 +/- ##
===========================================================
- Coverage 63.66% 63.62% -0.04%
===========================================================
Files 1768 1768
Lines 169051 169146 +95
Branches 4914 4914
===========================================================
+ Hits 107622 107627 +5
- Misses 53011 53096 +85
- Partials 8418 8423 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…t-integration # Conflicts: # docs/Contributing/SCIM-integration.md # ee/server/integrationtest/scim/scim_test.go # ee/server/scim/groups.go # ee/server/scim/users.go # server/datastore/mysql/scim_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #27284
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/
,orbit/changes/
oree/fleetd-chrome/changes
.See Changes files for more information.
SELECT *
is avoided, SQL injection is prevented (using placeholders for values in statements)cmd/osquery-perf
for new osquery data ingestion features.COLLATE utf8mb4_unicode_ci
).runtime.GOOS
).