Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCIM + host integration #27880

Draft
wants to merge 64 commits into
base: main
Choose a base branch
from
Draft

Conversation

getvictor
Copy link
Member

@getvictor getvictor commented Apr 4, 2025

For #27284

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
  • Added support on fleet's osquery simulator cmd/osquery-perf for new osquery data ingestion features.
  • If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes
  • If database migrations are included, checked table schema to confirm autoupdate
  • For database migrations:
    • Checked schema for all modified table for columns that will auto-update timestamps during migration.
    • Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects.
    • Ensured the correct collation is explicitly set for character columns (COLLATE utf8mb4_unicode_ci).
  • Added/updated automated tests
  • A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it)
  • Manual QA for all new/changed functionality
  • For Orbit and Fleet Desktop changes:
    • Make sure fleetd is compatible with the latest released version of Fleet (see Must rule).
    • Orbit runs on macOS, Linux and Windows. Check if the orbit feature/bugfix should only apply to one platform (runtime.GOOS).
    • Manual QA must be performed in the three main OSs, macOS, Windows and Linux.
    • Auto-update manual QA, from released version of component to new version (see tools/tuf/test).
  • For unreleased bug fixes in a release candidate, confirmed that the fix is not expected to adversely impact load test results or alerted the release DRI if additional load testing is needed.

Copy link

codecov bot commented Apr 4, 2025

Codecov Report

Attention: Patch coverage is 27.69231% with 47 lines in your changes missing coverage. Please review.

Project coverage is 63.62%. Comparing base (41f9081) to head (81fc52e).

Files with missing lines Patch % Lines
server/worker/apple_mdm.go 13.88% 29 Missing and 2 partials ⚠️
server/fleet/scim.go 0.00% 10 Missing ⚠️
ee/server/scim/groups.go 70.00% 3 Missing ⚠️
ee/server/scim/users.go 66.66% 3 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##           victor/27287-scim-tests   #27880      +/-   ##
===========================================================
- Coverage                    63.66%   63.62%   -0.04%     
===========================================================
  Files                         1768     1768              
  Lines                       169051   169146      +95     
  Branches                      4914     4914              
===========================================================
+ Hits                        107622   107627       +5     
- Misses                       53011    53096      +85     
- Partials                      8418     8423       +5     
Flag Coverage Δ
backend 64.64% <27.69%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from victor/27287-scim-tests to main April 4, 2025 16:00
…t-integration

# Conflicts:
#	docs/Contributing/SCIM-integration.md
#	ee/server/integrationtest/scim/scim_test.go
#	ee/server/scim/groups.go
#	ee/server/scim/users.go
#	server/datastore/mysql/scim_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant