-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fleet UI: Calendar settings design updates #17869
Conversation
4c73f9f
to
12663f0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17869 +/- ##
=======================================
Coverage 65.33% 65.33%
=======================================
Files 1204 1204
Lines 110022 110022
Branches 2585 2585
=======================================
Hits 71880 71880
Misses 32640 32640
Partials 5502 5502
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
👀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, let's please:
- Success/error flash messages should have "."s at the end, unless that decision was changed recently in which case we should replace all of them.
- Update API Key JSON and Primary domain validation error messages to use "completed" instead of "present"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving so we can merge before freeze, please address those comments as unreleased bugs, which they are!
Issue
Updates to #17444
Part of #17230
Screenshot
Checklist for submitter
If some of the following don't apply, delete the relevant line.