Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet UI: Calendar settings design updates #17869

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Conversation

RachelElysia
Copy link
Member

Issue

Updates to #17444
Part of #17230

Screenshot

Screenshot 2024-03-26 at 3 11 56 PM

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Manual QA for all new/changed functionality

@RachelElysia RachelElysia requested review from a team as code owners March 26, 2024 19:13
@RachelElysia RachelElysia removed the request for review from a team March 26, 2024 20:29
Base automatically changed from 17230-calendar-feature to main March 26, 2024 20:34
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.33%. Comparing base (9861f6e) to head (07ef1a7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17869   +/-   ##
=======================================
  Coverage   65.33%   65.33%           
=======================================
  Files        1204     1204           
  Lines      110022   110022           
  Branches     2585     2585           
=======================================
  Hits        71880    71880           
  Misses      32640    32640           
  Partials     5502     5502           
Flag Coverage Δ
frontend 51.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobshandling
Copy link
Contributor

👀

Copy link
Contributor

@jacobshandling jacobshandling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, let's please:

  • Success/error flash messages should have "."s at the end, unless that decision was changed recently in which case we should replace all of them.
  • Update API Key JSON and Primary domain validation error messages to use "completed" instead of "present"

@jacobshandling jacobshandling self-requested a review March 27, 2024 00:13
Copy link
Contributor

@jacobshandling jacobshandling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so we can merge before freeze, please address those comments as unreleased bugs, which they are!

@RachelElysia RachelElysia merged commit 4103acf into main Mar 27, 2024
12 checks passed
@RachelElysia RachelElysia deleted the calendar-settings-3 branch March 27, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants