Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch fleet v4.47.2 #17840

Closed
wants to merge 8 commits into from
Closed

Patch fleet v4.47.2 #17840

wants to merge 8 commits into from

Conversation

sharon-fdm
Copy link
Collaborator

No description provided.

getvictor and others added 8 commits March 13, 2024 18:15

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Merging the following bug fix PRs from main:
#17117
#16562

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…es. (#17722)

#17061

Already merged into main: #17709

# Checklist for submitter
- [x] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
See [Changes
files](https://fleetdm.com/docs/contributing/committing-changes#changes-files)
for more information.
- [x] Added/updated tests
- [x] Manual QA for all new/changed functionality

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Same as #17560

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Bump up `tools/fleetctl-npm/package.json`
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 85.35032% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 65.54%. Comparing base (88d4191) to head (4454fdb).
Report is 132 commits behind head on main.

Files Patch % Lines
server/service/hosts.go 73.91% 7 Missing and 5 partials ⚠️
server/datastore/mysql/hosts.go 91.54% 4 Missing and 2 partials ⚠️
frontend/pages/hosts/details/cards/About/About.tsx 0.00% 3 Missing ⚠️
server/mock/datastore_mock.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17840      +/-   ##
==========================================
- Coverage   65.61%   65.54%   -0.08%     
==========================================
  Files        1191     1191              
  Lines      107646   107714      +68     
  Branches     2567     2573       +6     
==========================================
- Hits        70633    70599      -34     
- Misses      31659    31740      +81     
- Partials     5354     5375      +21     
Flag Coverage Δ
fleetd-chrome 70.88% <ø> (ø)
frontend 51.94% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukeheath lukeheath closed this Mar 26, 2024
@lukeheath lukeheath deleted the patch-fleet-v4.47.2 branch March 26, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants