Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix merge to patch: Toast messages #17732

Closed
wants to merge 2 commits into from

Conversation

RachelElysia
Copy link
Member

@RachelElysia RachelElysia commented Mar 20, 2024

Issue

#17624

Description

Approved and merged to main already: #17674
Just needs to be merged to the patch.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.53%. Comparing base (8393c17) to head (9704cc7).

Additional details and impacted files
@@                   Coverage Diff                   @@
##           patch-fleet-v4.47.2   #17732      +/-   ##
=======================================================
- Coverage                65.54%   65.53%   -0.01%     
=======================================================
  Files                     1191     1191              
  Lines                   107709   107707       -2     
  Branches                  2573     2573              
=======================================================
- Hits                     70593    70591       -2     
  Misses                   31741    31741              
  Partials                  5375     5375              
Flag Coverage Δ
frontend 51.92% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@georgekarrv
Copy link
Member

Normally I would say ~unreleased-bugs don't need to be merged back to the patch since in theory it wasn't present there. But seeing as this has a change here then I think the issue should be updated to ~released-bug imo.

@lukeheath
Copy link
Member

Agreed with George, only needed if it's a released bug.

@RachelElysia
Copy link
Member Author

@georgekarrv @lukeheath @sharon-fdm

Confirmed this is unreleased and closing this out. It's a hidden bug surfaced when we updated react in commit 3c2e4b8 which is unreleased, so no need to patch it.

@RachelElysia RachelElysia deleted the toast-messages branch March 22, 2024 14:05
@sharon-fdm
Copy link
Collaborator

Makes sense @RachelElysia
I trust that we did merge this into main.

@RachelElysia
Copy link
Member Author

@sharon-fdm Yup, PR #17674 is in the ready for release column on our board

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants