-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix merge to patch: Toast messages #17732
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## patch-fleet-v4.47.2 #17732 +/- ##
=======================================================
- Coverage 65.54% 65.53% -0.01%
=======================================================
Files 1191 1191
Lines 107709 107707 -2
Branches 2573 2573
=======================================================
- Hits 70593 70591 -2
Misses 31741 31741
Partials 5375 5375
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Normally I would say |
Agreed with George, only needed if it's a released bug. |
@georgekarrv @lukeheath @sharon-fdm Confirmed this is unreleased and closing this out. It's a hidden bug surfaced when we updated react in commit 3c2e4b8 which is unreleased, so no need to patch it. |
Makes sense @RachelElysia |
@sharon-fdm Yup, PR #17674 is in the ready for release column on our board |
Issue
#17624
Description
Approved and merged to main already: #17674
Just needs to be merged to the patch.