-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add startup assistant to the UI #17731
add startup assistant to the UI #17731
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat-prefill-account-name #17731 +/- ##
============================================================
Coverage ? 65.63%
============================================================
Files ? 1195
Lines ? 108330
Branches ? 2581
============================================================
Hits ? 71098
Misses ? 31834
Partials ? 5398
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
13d30c8
to
f044397
Compare
f044397
to
7ae50b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I always learn something from reviewing your code!
frontend/pages/ManageControlsPage/SetupExperience/cards/SetupAssistant/SetupAssistant.tsx
Outdated
Show resolved
Hide resolved
frontend/pages/ManageControlsPage/SetupExperience/cards/SetupAssistant/SetupAssistant.tsx
Outdated
Show resolved
Hide resolved
frontend/pages/ManageControlsPage/SetupExperience/cards/SetupAssistant/SetupAssistant.tsx
Show resolved
Hide resolved
frontend/pages/ManageControlsPage/SetupExperience/cards/SetupAssistant/SetupAssistant.tsx
Outdated
Show resolved
Hide resolved
...ontrolsPage/SetupExperience/cards/SetupAssistant/components/AdvancedOptionsForm/_styles.scss
Show resolved
Hide resolved
...age/SetupExperience/cards/SetupAssistant/components/SetupAssistantProfileUploader/helpers.ts
Outdated
Show resolved
Hide resolved
@@ -73,7 +76,7 @@ const FileUploader = ({ | |||
variant="brand" | |||
isLoading={isLoading} | |||
> | |||
<label htmlFor="upload-profile">Upload</label> | |||
<label htmlFor="upload-profile">{buttonMessage}</label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more generic than "upload-profile"?
.../SetupExperience/cards/SetupAssistant/components/AdvancedOptionsForm/AdvancedOptionsForm.tsx
Outdated
Show resolved
Hide resolved
|
||
import Card from "components/Card"; | ||
|
||
import OsSetupPreview from "../../../../../../../../assets/images/os-setup-preview.gif"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo: update gif
/** | ||
* updates the team config. This can take any partial data that is in the team config. | ||
*/ | ||
updateConfig: (data: any, teamId: number): Promise<ITeamConfig> => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
niceee
@@ -0,0 +1,13 @@ | |||
import { uploadedFromNow } from "."; | |||
|
|||
describe("date_format", () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
niceee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet thanks for all this!
relates to #9147
add the setup assistant page to the UI. This includes:
changes/
ororbit/changes/
.See Changes files for more information.