[released bug] Fleet UI: standard query library platforms render prop… #17712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17712 +/- ##
=======================================
Coverage 65.67% 65.67%
=======================================
Files 1193 1193
Lines 108026 108026
Branches 2574 2574
=======================================
Hits 70947 70947
Misses 31709 31709
Partials 5370 5370
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -724,7 +724,7 @@ const EditQueryForm = ({ | |||
| placeholder="Select" | |||
| label="Platform" | |||
| onChange={onChangeSelectPlatformOptions} | |||
| value={lastEditedQueryPlatforms} | |||
| value={lastEditedQueryPlatforms.replace(/\s/g, "")} // NOTE: FE requires no whitespace to render UI | |||
There was a problem hiding this comment.
just want to .replaceAll here
jacobshandling
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Cerra #17662
This fix is also in Feature PR #17663 but added here so if we want to include it in a patch
Description
Alternative was to modify the
Dropdowncomponent to allow joins with", "and","but that was complicating the component for a one-off issue.Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/ororbit/changes/.