Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerabilities Page: Wire up with API #17012

Closed
wants to merge 1 commit into from
Closed

Conversation

RachelElysia
Copy link
Member

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/ or orbit/changes/.
    See Changes files for more information.
  • Documented any permissions changes (docs/Using Fleet/manage-access.md)
  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
  • Added support on fleet's osquery simulator cmd/osquery-perf for new osquery data ingestion features.
  • Added/updated tests
  • If database migrations are included, checked table schema to confirm autoupdate
  • For database migrations:
    • Checked schema for all modified table for columns that will auto-update timestamps during migration.
    • Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects.
  • Manual QA for all new/changed functionality
    • For Orbit and Fleet Desktop changes:
      • Manual QA must be performed in the three main OSs, macOS, Windows and Linux.
      • Auto-update manual QA, from released version of component to new version (see tools/tuf/test).

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.99%. Comparing base (b911b36) to head (634e12b).
Report is 97 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17012      +/-   ##
==========================================
+ Coverage   65.97%   65.99%   +0.02%     
==========================================
  Files        1144     1144              
  Lines      101466   101365     -101     
  Branches     2520     2539      +19     
==========================================
- Hits        66940    66900      -40     
+ Misses      29554    29499      -55     
+ Partials     4972     4966       -6     
Flag Coverage Δ
frontend 51.88% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from 15919-vulnerabilities-page to main February 23, 2024 17:00
@RachelElysia
Copy link
Member Author

Already in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant