fix: filter out software from parallels vm #16520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roperzh
reviewed
Jan 31, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #16520 +/- ##
==========================================
+ Coverage 65.52% 65.53% +0.01%
==========================================
Files 1132 1132
Lines 99069 99077 +8
Branches 2448 2448
==========================================
+ Hits 64916 64933 +17
+ Misses 29266 29256 -10
- Partials 4887 4888 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Roberto Dip <[email protected]>
roperzh
approved these changes
Jan 31, 2024
georgekarrv
pushed a commit
that referenced
this pull request
Feb 9, 2024
> Related issue: #15855 I followed a similar pattern to `sanitizeSoftware`, a function that modifies the `Software`. I was originally going to update `sanitizeSoftware` itself, but decided against it 1. to avoid making lots of changes to the function signature and internals 2. because the logic this issue requires is pretty different from what `sanitizeSoftware` is trying to do, so seemed to warrant its own function. # Checklist for submitter If some of the following don't apply, delete the relevant line. <!-- Note that API documentation changes are now addressed by the product design team. --> - [x] Changes file added for user-visible changes in `changes/` or `orbit/changes/`. See [Changes files](https://fleetdm.com/docs/contributing/committing-changes#changes-files) for more information. - [x] Added/updated tests - [x] Manual QA for all new/changed functionality --------- Co-authored-by: Roberto Dip <[email protected]>
georgekarrv
pushed a commit
that referenced
this pull request
Feb 13, 2024
> Related issue: #15855 I followed a similar pattern to `sanitizeSoftware`, a function that modifies the `Software`. I was originally going to update `sanitizeSoftware` itself, but decided against it 1. to avoid making lots of changes to the function signature and internals 2. because the logic this issue requires is pretty different from what `sanitizeSoftware` is trying to do, so seemed to warrant its own function. # Checklist for submitter If some of the following don't apply, delete the relevant line. <!-- Note that API documentation changes are now addressed by the product design team. --> - [x] Changes file added for user-visible changes in `changes/` or `orbit/changes/`. See [Changes files](https://fleetdm.com/docs/contributing/committing-changes#changes-files) for more information. - [x] Added/updated tests - [x] Manual QA for all new/changed functionality --------- Co-authored-by: Roberto Dip <[email protected]>
georgekarrv
pushed a commit
that referenced
this pull request
Feb 13, 2024
> Related issue: #15855 I followed a similar pattern to `sanitizeSoftware`, a function that modifies the `Software`. I was originally going to update `sanitizeSoftware` itself, but decided against it 1. to avoid making lots of changes to the function signature and internals 2. because the logic this issue requires is pretty different from what `sanitizeSoftware` is trying to do, so seemed to warrant its own function. # Checklist for submitter If some of the following don't apply, delete the relevant line. <!-- Note that API documentation changes are now addressed by the product design team. --> - [x] Changes file added for user-visible changes in `changes/` or `orbit/changes/`. See [Changes files](https://fleetdm.com/docs/contributing/committing-changes#changes-files) for more information. - [x] Added/updated tests - [x] Manual QA for all new/changed functionality --------- Co-authored-by: Roberto Dip <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I followed a similar pattern to
sanitizeSoftware, a function that modifies theSoftware. I was originally going to updatesanitizeSoftwareitself, but decided against itsanitizeSoftwareis trying to do, so seemed to warrant its own function.Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/ororbit/changes/.See Changes files for more information.