Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to verify profiles that are pending #15911

Merged
merged 6 commits into from
Jan 4, 2024
Merged

Conversation

roperzh
Copy link
Contributor

@roperzh roperzh commented Jan 4, 2024

for #15678

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/ or orbit/changes/.
    See Changes files for more information.
  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
  • Added/updated tests
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3b00b70) 66.19% compared to head (41ae5ae) 66.05%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15911      +/-   ##
==========================================
- Coverage   66.19%   66.05%   -0.14%     
==========================================
  Files        1067     1067              
  Lines       93564    93571       +7     
  Branches     2341     2341              
==========================================
- Hits        61934    61811     -123     
- Misses      27021    27139     +118     
- Partials     4609     4621      +12     
Flag Coverage Δ
backend 67.24% <100.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roperzh roperzh marked this pull request as ready for review January 4, 2024 21:11
@roperzh roperzh requested a review from a team as a code owner January 4, 2024 21:11
Copy link
Contributor

@gillespi314 gillespi314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@roperzh roperzh merged commit 18d830a into main Jan 4, 2024
@roperzh roperzh deleted the profile-verification branch January 4, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants