Containerd improvement #149
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from main repo
Sync upstream
Update from upstream
|
This is a replacement/improvement of the following PR #130 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Containerd Improvements
Currently containerd is included in the sysexts of docker, k3s, etc. This will remove containerd from them directly and create a new sysext for each like: containerd-
This allows us to still provide containerd that comes with docker, k3s, etc while allowing it to be switched out with that of upstream or different ones without causing any issues.
It will automatically build the extension during build time of the upstream sysext of docker, k3s, etc.
I really think we should do something to better handle containerd and I think this is a good compromise. I will add k3s and any others to this PR but want to make sure this is the route we want to go before spending all the time doing that and updating docs as well.
Testing done
Included in this pull request is test-build.sh that I used to test building that I will remove. This will need more testing especially w/ the github build system to make sure everything is built correctly.