Skip to content

Keepalived: Fix used alpine image #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 9, 2025
Merged

Keepalived: Fix used alpine image #138

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a3e823a
Fix used alpine image
UnholyRope Apr 1, 2025
86e01fa
Don't specify image arch in the image path
UnholyRope Apr 2, 2025
8bea24a
Add latest keepalived version to release_build_versions
UnholyRope Apr 2, 2025
4e2c5b3
Remove build output from Release.md
UnholyRope Apr 3, 2025
9ed5ae7
Merge branch 'flatcar:main' into keepalived-alpine
UnholyRope Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions keepalived.sysext/create.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ function populate_sysext_root() {
local img_arch="$(arch_transform 'x86-64' 'amd64' "$arch")"
img_arch="$(arch_transform 'arm64' 'arm64/v8' "$img_arch")"

local image="docker.io/${img_arch}/alpine:3.19"
local image="docker.io/${img_arch}/alpine:3.21"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
local image="docker.io/${img_arch}/alpine:3.21"
local image="docker.io/alpine:3.21"

as we explicitly specify --platform on the docker run command line. For some reason the original version even workd for x86-64 but breaks for arm64.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that. I updated it accordingly.


announce "Building keepalived $version for $arch"

Expand All @@ -31,7 +31,7 @@ function populate_sysext_root() {
-v "$(pwd)":/install_root \
--platform "linux/${img_arch}" \
--pull always \
alpine:v3.21 \
${image} \
/install_root/build.sh "${version}" "$user_group"

# /usr/sbin is a symlink to /usr/bin on Flatcar.
Expand Down