Skip to content

keepalived: do not use /usr/sbin #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2025
Merged

Conversation

t-lo
Copy link
Member

@t-lo t-lo commented Mar 29, 2025

/usr/sbin is a symlink to /usr/bin on recent Flatcar releases. Sysexts shipping /usr/sbin would overwrite that symlink and sbin would contain only the contents that sysext ships.

We copy keepalived to /usr/bin and also pin the Alpine Linux release used for the build.

After merge we need to delete the keepalived releases to force a rebuild.

Fixes #131

/usr/sbin is a symlink to /usr/bin on recent Flatcar releases. Sysexts
shipping /usr/sbin would overwrite that symlink and sbin would contain
only the contents that sysext ships.

We copy keepalived to /usr/bin and also pin the Alpine Linux release
used for the build.

Signed-off-by: Thilo Fromm <[email protected]>
@t-lo t-lo requested a review from a team March 29, 2025 14:12
Copy link
Contributor

@ader1990 ader1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chewi chewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but I wonder if we can avoid this more generally by populating sysextroot with symlinks in the first place?

@t-lo
Copy link
Member Author

t-lo commented Mar 31, 2025

This is fine, but I wonder if we can avoid this more generally by populating sysextroot with symlinks in the first place?

@chewi Yes, that's definitely something we should investigate. Like, force-abort a build with an error message in lib/generate.sh when we detect /usr/sbin to be present.

@t-lo t-lo merged commit d548304 into main Mar 31, 2025
@t-lo t-lo deleted the t-lo/keepalived-dont-use-sbin branch March 31, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keepalived sysext overwrites Flatcar's sbin/ symlink
3 participants