Skip to content

Fix carousel page count calculation and fix carousel id #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ervcz
Copy link
Contributor

@ervcz ervcz commented Mar 31, 2025

1. Fix carousel page calculation for mobile view

Div in hugo.math was returning integers, which made the page calculation process incorrect showing only one page instead of two for the sponsors section (i.e. in case of 7 sponsors; 7 divided by 4 is ~1.75, so two pages should be shown). This PR fixes the calculation by taking the rest of the division into account.

2. Little style adjustments for mobile devices in the new community link section

Test

Sponsors carousel should show two pages on smaller screen sizes.

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://lemon-wave-085522403-410.westeurope.1.azurestaticapps.net

@ervcz ervcz requested a review from a team March 31, 2025 18:12
@ervcz ervcz changed the title Improve page count calculation and fix carousel id Fix page count calculation and fix carousel id Apr 1, 2025
@ervcz ervcz changed the title Fix page count calculation and fix carousel id Fix carousel page count calculation and fix carousel id Apr 1, 2025
@ervcz ervcz requested a review from Copilot April 1, 2025 08:12
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (3)
  • themes/flatcar/assets/scss/partials/community-links.scss: Language not supported
  • themes/flatcar/layouts/partials/community-links.html: Language not supported
  • themes/flatcar/layouts/partials/companies.html: Language not supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant