misc: jit: Import jit_env as a module #1073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abcdabcd987
force-pushed
the
lequn/jit-env
branch
from
54b0007 to
ebb654b
Compare
abcdabcd987
force-pushed
the
lequn/remove-parallel-load-modules
branch
from
5ad71da to
20892f7
Compare
abcdabcd987
force-pushed
the
lequn/jit-env
branch
from
ebb654b to
5adec0d
Compare
abcdabcd987
force-pushed
the
lequn/remove-parallel-load-modules
branch
from
20892f7 to
ed480f6
Compare
abcdabcd987
force-pushed
the
lequn/jit-env
branch
from
5adec0d to
addf31d
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the way JIT environment variables and constants are imported by switching to a module‑based import (using jit_env) so that the AOT script can override environment variables.
- Changed all direct imports of FLASHINFER_* constants from .jit.env to fetching them via jit_env
- Adjusted import orders across multiple modules and updated associated file paths accordingly
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| flashinfer/sampling.py | Updated imports to use jit_env and split FLASHINFER_CSRC_DIR usage. |
| flashinfer/rope.py | Similar update: replaced direct FLASHINFER_CSRC_DIR with jit_env. |
| flashinfer/quantization.py | Updated the import of FLASHINFER_CSRC_DIR via jit_env. |
| flashinfer/page.py | Updated FLASHINFER_CSRC_DIR lookup to use jit_env. |
| flashinfer/norm.py | Replaced direct FLASHINFER_CSRC_DIR usage with jit_env reference. |
| flashinfer/mla.py | Updated both FLASHINFER_CSRC_DIR and CUTLASS_INCLUDE_DIRS to be accessed via jit_env. |
| flashinfer/jit/env.py | Added documentation and note discouraging direct import from .jit.env. |
| flashinfer/jit/cpp_ext.py | Updated FLASHINFER_DATA usage to jit_env reference. |
| flashinfer/jit/core.py | Adjusted directory creation and file path construction to use jit_env. |
| flashinfer/jit/attention/tvm.py | Updated constants access to use jit_env for source and generated path resolution. |
| flashinfer/jit/attention/pytorch.py | Updated imports to reference jit_env for FLASHINFER_* constants. |
| flashinfer/jit/activation.py | Updated FLASHINFER_GEN_SRC_DIR to be accessed via jit_env. |
| flashinfer/jit/init.py | Removed wildcard import of .env and re-exported jit_env explicitly. |
| flashinfer/gemm.py | Updated all FLASHINFER_CSRC_DIR calls to use jit_env. |
| flashinfer/custom_all_reduce.py | Updated constants import to reference jit_env. |
| flashinfer/cascade.py | Replaced FLASHINFER_CSRC_DIR usage with jit_env in module generation. |
yzh119
approved these changes
May 22, 2025
Edenzzzz
pushed a commit
to Edenzzzz/flashinfer
that referenced
this pull request
Jun 6, 2025
Part of AOT Refactor (flashinfer-ai#1064). Change from ```python from .jit.env import FLASHINFER_XXX ``` to ```python from .jit import env as jit_env jit_env.FLASHINFER_XXX ``` This allows the AOT script to override the env vars.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of AOT Refactor (#1064).
Change from
to
This allows the AOT script to override the env vars.