misc: jit: Replace parallel_load_modules() with build_jit_specs() #1070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abcdabcd987
force-pushed
the
lequn/split-gen-jitspec
branch
from
4556311 to
e863698
Compare
abcdabcd987
force-pushed
the
lequn/remove-parallel-load-modules
branch
from
d4d5497 to
5ad71da
Compare
abcdabcd987
force-pushed
the
lequn/split-gen-jitspec
branch
from
e863698 to
2d38830
Compare
abcdabcd987
force-pushed
the
lequn/remove-parallel-load-modules
branch
from
5ad71da to
20892f7
Compare
abcdabcd987
force-pushed
the
lequn/split-gen-jitspec
branch
from
2d38830 to
cfd4539
Compare
abcdabcd987
force-pushed
the
lequn/remove-parallel-load-modules
branch
from
20892f7 to
ed480f6
Compare
yzh119
approved these changes
May 22, 2025
Edenzzzz
pushed a commit
to Edenzzzz/flashinfer
that referenced
this pull request
Jun 6, 2025
…ashinfer-ai#1070) Part of AOT Refactor (flashinfer-ai#1064). Now that `build_jit_specs()` can build all ops in one ninja run, there's no need for `parallel_load_modules()` in tests. Also fixing a bad pattern: ```python try: flashinfer.jit.parallel_load_modules(...) except Exception as e: pytest.exit(str(e)) finally: yield ``` This will not stop pytest when error is raised, because there's a `finally` clause. Also, the default exit code of `pytest.exit()` is 0, so it doesn't indicate an error. An easy fix would be just to get rid of the whole `try-except-finally` structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of AOT Refactor (#1064).
Now that
build_jit_specs()can build all ops in one ninja run, there's no need forparallel_load_modules()in tests.Also fixing a bad pattern:
This will not stop pytest when error is raised, because there's a
finallyclause. Also, the default exit code ofpytest.exit()is 0, so it doesn't indicate an error.An easy fix would be just to get rid of the whole
try-except-finallystructure.