[ci] add nonamedreturns linter #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikhail Scherba <[email protected]>
Signed-off-by: Mikhail Scherba <[email protected]>
ldmonster
reviewed
Dec 18, 2024
juev
approved these changes
Dec 18, 2024
pkg/hook/hook_manager.go
Outdated
| @@ -201,7 +201,7 @@ func (hm *Manager) loadHook(hookPath string) (hook *Hook, err error) { | |||
| hook.WithTmpDir(hm.TempDir()) | |||
|
|
|||
| if hook.Config == nil { | |||
| return nil, fmt.Errorf("hook %q is marked as executable but doesn't contain config section", hook.Path) | |||
| return nil, fmt.Errorf("hook %s is marked as executable but doesn't contain config section", hook.Path) | |||
There was a problem hiding this comment.
Why are we changing %q to %s here? Thus, the hook name will now be without quotes.
ldmonster
reviewed
Dec 18, 2024
Signed-off-by: Mikhail Scherba <[email protected]>
ldmonster
approved these changes
Dec 19, 2024
yalosev
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds nonamedreturns linter.
What this PR does / why we need it
Special notes for your reviewer