[schedule-manager] fix entry clean-up #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikhail Scherba <[email protected]>
yalosev
approved these changes
Oct 14, 2024
miklezzzz
added a commit
that referenced
this pull request
Oct 15, 2024
Signed-off-by: Mikhail Scherba <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Updates the
schedule-manager's Remove method to clean-up an entry from theEntriesmap if there are no associated schedule bindings left with the entry.What this PR does / why we need it
It corrects the way schedule bindings of a module cleaned-up when the module is disabled. And, If the module is re-enabled, its schedule bindings are recreated correctly.
Special notes for your reviewer