feat: no cgo build #238
Merged
feat: no cgo build #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
removed
the
run/tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
flant/libjq-go is required only if cgo is enabled.
What this PR does / why we need it
Build with CGO_ENABLED=0 is not require libjq-go anymore, so it is possible to use various parts of the shell-operator in projects that don't require jqFilter. For example, Kubernetes client in
pkg/kubeor Prometheus client inpkg/metric_storageor Monitors with custom FilterFunc inpkg/kube_events_manager.JQ_EXEC=yesenvironment variable still can be used to force/usr/bin/jqexecution if the shell-operator is built with cgo enabled.Special notes for your reviewer
Does this PR introduce a user-facing change?