feat: add type field for group and schedule #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix name for CombineBindingContextForHook - disable combine contexts for v0 hooks
diafour
force-pushed
the
feat_type_for_group_and_schedule
branch
from
a2dd9e8 to
09e3968
Compare
This was referenced Mar 25, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
typefield for group can beSynchronizationif at most one binding context in a group hadSynchronizationtype. If grouped contexts do not haveSynchronizationcontext, then the type isGroup.A binding context for Schedule now has field type with value
Schedule.Fixes #156.