feat: add GetReleaseChecksum method and update UpgradeRelease signature

[juev]

Overview

Transferring the release checksum storage from variables to labels

What this PR does / why we need it

Transfer the storage of checksums from environment variables to release tags

[Copilot]

Pull Request Overview

This PR updates the checksum storage mechanism for Helm releases by transferring the checksum from environment variables to release labels, and it adjusts the UpgradeRelease method signatures across multiple packages.

• Moves checksum storage from variables to release labels in HelmModule
• Introduces a new GetReleaseChecksum method for both helm3lib and helm3 packages
• Updates UpgradeRelease method signatures and related calls in tests and client interfaces

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
pkg/module_manager/models/modules/helm.go	Updates RunHelmInstall and shouldRunHelmUpgrade to utilize release labels for the module checksum
pkg/helm/helm_test.go	Updates test to call the new UpgradeRelease signature with labels
pkg/helm/helm3lib/helm3lib.go	Updates UpgradeRelease and introduces GetReleaseChecksum with labels
pkg/helm/helm3/helm3.go	Adjusts the UpgradeRelease signature and provides a GetReleaseChecksum implementation
pkg/helm/client/client.go	Updates interface definitions to include new labels parameter and GetReleaseChecksum

Comments suppressed due to low confidence (2)

pkg/helm/helm3lib/helm3lib.go:205

• Ensure that upg.Labels is initialized (e.g., to an empty map) before calling maps.Copy to avoid potential nil pointer issues when labels are provided.

maps.Copy(upg.Labels, labels)

pkg/helm/helm3/helm3.go:142

• The labels parameter is currently ignored in the Helm3 client UpgradeRelease implementation. Consider handling the moduleChecksum label similarly to the helm3lib version, or remove the unused parameter if not needed.

func (h *Helm3Client) UpgradeRelease(releaseName string, chart string, valuesPaths []string, setValues []string, _ map[string]string, namespace string) error {

[Copilot]

Pull Request Overview

This PR transfers storage of release checksums from environment variables to release labels and updates the UpgradeRelease signature across multiple modules. Key changes include:

• Adding a new GetReleaseChecksum method to retrieve the checksum from release labels.
• Updating the UpgradeRelease signature to accept a labels parameter instead of a set values slice.
• Adjusting tests and mocks to use the new method signatures.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
pkg/module_manager/models/modules/helm.go	Replaced checksum storage with label-based storage in helm install and upgrade logic.
pkg/helm/test/mock/mock.go	Introduced GetReleaseChecksum and updated UpgradeRelease signature.
pkg/helm/helm_test.go	Updated test calls to match the new UpgradeRelease signature.
pkg/helm/helm3lib/helm3lib.go	Updated UpgradeRelease and upgradeRelease methods to handle labels; added GetReleaseChecksum.
pkg/helm/helm3/helm3.go	Updated UpgradeRelease and added GetReleaseChecksum implementation.
pkg/helm/client/client.go	Updated HelmClient interface with new method signature for UpgradeRelease and added GetReleaseChecksum.

[ldmonster]

i think we need to start write tests for helm methods behaviour.

f.e. add this method for LibClient (not interface) and test with it

// ListReleases returns list of releases
func (h *LibClient) ListReleases() ([]*release.Release, error) {
	l := action.NewList(actionConfig)
	// list all releases regardless of their state
	l.StateMask = action.ListAll
	list, err := l.Run()
	if err != nil {
		return nil, fmt.Errorf("helm list failed: %s", err)
	}

	return list, nil
}

[yalosev]

didn't get the clue. why not to pass labels directly to the upgrade cli. Do the upgradeCli modify them?

[yalosev]

also have to add to the installCli below

[juev]

I tried to protect myself a little. But yes, you can just ignore the current labels and just make an assignment.

instClient also corrected it.