-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[addon-operator] feat/minor improvements two #578
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
bc3925f
to
a03b472
Compare
Signed-off-by: Pavel Okhlopkov <[email protected]>
a03b472
to
64ad324
Compare
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
…or-improvements-two Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
…or-improvements-two Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
Signed-off-by: Pavel Okhlopkov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces minor improvements and refactoring to the addon-operator codebase, focusing on task handling, module management, and debug/metric endpoints. The changes improve context propagation in function signatures, update metric and log label usage to ensure consistency, and enhance debugging endpoints.
Reviewed Changes
Copilot reviewed 39 out of 40 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
pkg/task/global-hook-enable-kubernetes-bindings/task.go | Implements task handler for global hooks with refined scheduling and log labels. |
pkg/task/discover-helm-release/task.go | Adds task to discover Helm releases and create purge tasks. |
pkg/task/apply-kube-config-values/task.go | Introduces a new task for applying Kubernetes configuration values with improved error logs. |
pkg/module_manager/scheduler/scheduler.go | Refactors GetGraphImage to include a context argument for consistency with API changes. |
pkg/module_manager/module_manager.go | Updates HandleKubeEvent and HandleScheduleEvent signatures to return tasks and use new factories. |
pkg/module_manager/models/* | Updates metric label keys and improves logging for synchronization, helm, global, and basic hooks. |
pkg/labels.go | Defines common log and metric label keys used throughout the code. |
pkg/addon-operator/* (operator_test.go, metrics.go, http_server.go, etc.) | Adapts tests and HTTP handlers to new task handler service and context parameters; refines debug routes. |
pkg/addon-operator/handler_module_manager.go | Refactors module manager event handling, including dynamic and kube config events. |
pkg/addon-operator/handler_manager_events.go | Registers event handlers for schedule and Kubernetes events with task factories. |
pkg/addon-operator/converge/converge.go | Changes type name for first run phase for clarity and implements Stringer for the converge event. |
pkg/addon-operator/bootstrap.go and cmd/addon-operator/main.go | Improves bootstrap and main startup flow by initializing TaskService and adding more logging. |
Files not reviewed (1)
- go.mod: Language not supported
Overview
Move http services to separated files
Bump graphviz lib to fix compilations problem
Move task handling logic to task service
Add comments
What this PR does / why we need it
BEFORE:
We have task handling in Addon Operator.
All task handling functions was logic of Addon Operator.
Tasks handling functions knows about Shell Operator functions and actively use them
NOW:
We have Task Service which can work with new (Addon Operator) Task wrapper, which knows by himself how to handle task.
To isolate Shell Operator from tasks, we have Queue Service, which operate with Shell Operator (engine), and give to Tasks only hight level contract functions.
Special notes for your reviewer