-
Notifications
You must be signed in to change notification settings - Fork 27
Scheduler #465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Scheduler #465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1e45790
to
dd04cd5
Compare
80544c0
to
557b081
Compare
5dccd62
to
d888ada
Compare
yalosev
commented
May 17, 2024
32112f1
to
2df067e
Compare
0a9dbbf
to
392105e
Compare
yalosev
commented
May 29, 2024
ab7d367
to
1d86271
Compare
7c713fe
to
29b172c
Compare
add dynamically enabled extender Signed-off-by: Mikhail Scherba <[email protected]>
Signed-off-by: Mikhail Scherba <[email protected]>
Signed-off-by: Mikhail Scherba <[email protected]>
Signed-off-by: Mikhail Scherba <[email protected]> Co-authored-by: Yuriy Losev <[email protected]>
Signed-off-by: Mikhail Scherba <[email protected]>
Signed-off-by: Mikhail Scherba <[email protected]>
Signed-off-by: Mikhail Scherba <[email protected]>
Signed-off-by: Mikhail Scherba <[email protected]>
354b899
to
2b54206
Compare
Signed-off-by: Mikhail Scherba <[email protected]>
2b54206
to
153e001
Compare
miklezzzz
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
module status changed
event is sent if the module's enabled status wasn't changed, but the reason why module is enabled/disabled has changed.What this PR does / why we need it
This pr introduces a new sub-component of Module Manager - Module Scheduler, which aim is to decide which Module Manager's modules should be enabled or disabled by means of calculating a graph of the modules (DAG), traversing the graph and applying various module Filters (called Extenders). Currently, there are four basic extenders to filter modules' status:
The order extenders applied is up to the user, yet a default list of applied extenders is provided. It's up to the user to add any new extenders, following provided extender interface.
Also, there are numerous changes to other components of the operator in the pr to suit the new graph-based model.
Special notes for your reviewer