Skip to content

Relax the check about chrome profiles #5439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

julienw
Copy link
Contributor

@julienw julienw commented Apr 30, 2025

Fixes #5429

Comment on lines -221 to -225
event &&
typeof event === 'object' &&
'ph' in event &&
'cat' in event &&
'args' in event
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The trace doesn't have cat nor args so I went with a simpler check.
Then I decided to look at more than just the first event, so that we'd have some more certainty.

@julienw julienw requested a review from canova April 30, 2025 15:22
Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.04%. Comparing base (8b83c7a) to head (7aa3739).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5439   +/-   ##
=======================================
  Coverage   86.03%   86.04%           
=======================================
  Files         312      312           
  Lines       30365    30361    -4     
  Branches     8299     8295    -4     
=======================================
- Hits        26126    26123    -3     
+ Misses       3645     3644    -1     
  Partials      594      594           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@canova canova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support array format of chrome event trace
2 participants