Skip to content

Do not fail when the input isn't valid UTF-8 #5426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

julienw
Copy link
Contributor

@julienw julienw commented Apr 14, 2025

Because we accept arbitrary strings in markers, having non-valid UTF-8 could happen sometimes (even though this would be a bug in Firefox). But with the current code this fails the whole import. Instead we can try to be more gentle and accept the profile still.

Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.03%. Comparing base (90bb6f3) to head (b287631).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5426   +/-   ##
=======================================
  Coverage   86.03%   86.03%           
=======================================
  Files         312      312           
  Lines       30365    30365           
  Branches     8299     8299           
=======================================
  Hits        26126    26126           
  Misses       3645     3645           
  Partials      594      594           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@julienw julienw marked this pull request as ready for review April 14, 2025 14:05
@julienw julienw requested a review from mstange April 14, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant