Skip to content

[Deploy] Change default symbol server to a reliost instance #5407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[Deploy] Change default symbol server to a reliost instance #5407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app-logic/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ export const PROFILER_SERVER_ORIGIN = 'https://api.profiler.firefox.com';
// [1] https://github.com/mstange/profiler-symbol-server/

// This is the default server.
export const SYMBOL_SERVER_URL = 'https://symbolication.services.mozilla.com';
export const SYMBOL_SERVER_URL = 'https://profiler-symbolication.uk.r.appspot.com';

// See the MarkerPhase type for more information.
export const INSTANT: MarkerPhase = 0;
Expand Down
2 changes: 1 addition & 1 deletion src/utils/fetch-assembly.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export async function fetchAssembly(
// official Mozilla symbolication server with requests it can't handle.
// This check can be removed once it adds support for /asm/v1.
function _serverMightSupportAssembly(symbolServerUrl: string): boolean {
return isLocalURL(symbolServerUrl);
return isLocalURL(symbolServerUrl) || symbolServerUrl.endsWith('appspot.com');
}

// Convert the response from the JSON format into our own DecodedInstruction
Expand Down