Display tracer argument values via DevTool's Reps components #5393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on top of #5363 and start using DevTools Reps React component to render nice previews for the recorded objects.
For now, this is a gross integration crash landing Reps into the profiler, but I should probably spawn an npm package for Reps in order to improve the integration into the profiler frontend.
A few takeaways:
At first sight, it looks like the difference of React version between profiler and devtools doesn't introduce immediate failure
DevTools is using .mjs file extension whereas the profiler is using .js.
This difference is going to be invisible once Reps is packaged into an npm package.
DevTools uses URIs for imports, whereas the profiler uses require path.
This will still be something to handle while exporting Reps from mozilla-central/DevTools to npm.
This may be addressed by moving to relative paths.
Circular dependencies are forbidden by the profiler build toolchain.
This is something we can fix in DevTools. There circular dependencies can be avoided.
Reps depends on DevTools variables.css in order to render correctly, with the proper colors.
I'm not sure we want to import so many rules. It also depends on the very devtools specific
.theme-lightversus.theme-darkclass name.We may have to manually translate Reps's variable into colors already used in profiler?
DevTools isn't using JSX and requires React DOM Factories module/package.
Sounds fine importing this package as a profiler dependency?
I imagine this will be transparent once Reps is bundled into an npm package?
DevTools uses PropTypes
Same resolution as React DOM Factories.