WIP share more between threads #5273
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstange
force-pushed
the
push-wsuwrvunnvmr
branch
2 times, most recently
from
a5c010a to
f036db9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5273 +/- ##
==========================================
+ Coverage 86.03% 86.05% +0.01%
==========================================
Files 312 313 +1
Lines 30352 30708 +356
Branches 8292 8340 +48
==========================================
+ Hits 26114 26425 +311
- Misses 3644 3686 +42
- Partials 594 597 +3 ☔ View full report in Codecov by Sentry. |
mstange
force-pushed
the
push-wsuwrvunnvmr
branch
from
f036db9 to
5f8c157
Compare
mstange
force-pushed
the
push-wsuwrvunnvmr
branch
6 times, most recently
from
3779d4d to
eaa6409
Compare
mstange
force-pushed
the
push-wsuwrvunnvmr
branch
8 times, most recently
from
694bfc7 to
1995527
Compare
In the future we're planning to share more tables across threads, starting with the string table. If a user wants to upload only visible threads, there's the risk of keeping data from other threads in the profile if more of that data is shared across threads. So this commit adds a "compacting garbage collection" step before uploading, so that only data which is referenced within the sanitized profile is kept in the profile.
mstange
force-pushed
the
push-wsuwrvunnvmr
branch
from
1995527 to
479e098
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.