Fix marker-only compare profiles #5130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienw
requested changes
Sep 20, 2024
|
Thanks for the review, I'm planning on addressing fixes (next week), as I'm needing this for some CI perf work I'm doing. |
gregtatum
force-pushed
the
compare-markers-only
branch
from
c72e912 to
c567f1f
Compare
|
Thanks for the review and the correctness fixes. I addressed the comments. |
gregtatum
force-pushed
the
compare-markers-only
branch
from
c567f1f to
7b1971e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5130 +/- ##
==========================================
- Coverage 88.56% 88.56% -0.01%
==========================================
Files 307 307
Lines 27924 27931 +7
Branches 7556 7559 +3
==========================================
+ Hits 24730 24736 +6
- Misses 2977 2978 +1
Partials 217 217 ☔ View full report in Codecov by Sentry. |
Merged
canova
added a commit
that referenced
this pull request
Oct 24, 2024
[Markus Stange] Fix links to setup-startup-profiling.py post monorepo migration. (#5162) [Greg Tatum] Fix marker-only compare profiles (#5130) [Greg Tatum] Copy over the profile meta when merging profiles (#5131) [Nazım Can Altınova] Change the 'is-ready' postMessage pairs to 'ready:request' and 'ready:response' to be more explicit (#5148) [Julien Wajsberg] Fix timestamp issues in local tests (#5167) Also thanks to our localizers for contributing: fur: Fabio Tomat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5129.