Skip to content

change and moved op text #4848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 15, 2023
Merged

change and moved op text #4848

merged 3 commits into from
Dec 15, 2023

Conversation

Carla-Moz
Copy link
Contributor

@Carla-Moz Carla-Moz commented Dec 13, 2023 •
edited by julienw
Loading

@Carla-Moz Carla-Moz requested a review from a team as a code owner December 13, 2023 01:55
@Carla-Moz
Copy link
Contributor Author

@julienw and @canova see here for updated PR

@codecov Codecov
Copy link

codecov bot commented Dec 13, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f0b736f) 88.38% compared to head (81ddb68) 88.38%.

❗ Current head 81ddb68 differs from pull request most recent head 2264cb3. Consider uploading reports for the commit 2264cb3 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4848   +/-   ##
=======================================
  Coverage   88.38%   88.38%           
=======================================
  Files         301      301           
  Lines       26876    26876           
  Branches     7268     7268           
=======================================
  Hits        23754    23754           
  Misses       2906     2906           
  Partials      216      216

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

julienw
julienw approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@julienw julienw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Let's wait for the r? from Flod now.

@julienw julienw enabled auto-merge (squash) December 15, 2023 10:36
@julienw julienw merged commit 0ada127 into firefox-devtools:main Dec 15, 2023
@julienw
Copy link
Contributor

julienw commented Dec 15, 2023

Congrats for your first PR in the profiler @Carla-Moz !

@julienw julienw mentioned this pull request Dec 18, 2023
Merged
julienw added a commit that referenced this pull request Dec 18, 2023
@julienw
Deploy Dec 18, 2023 (#4862)
09286ed 
[Greg Tatum] Allow pages to inject profiles directly into the profiler via the postMessage API (Merge PR #4835)
[Carla Severe] Change and move the text about operations in the memory track tooltip (#4848)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienw julienw julienw approved these changes

@flodolo flodolo flodolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Operations since the previous sample" should be at end of the list in memory chart
3 participants
@Carla-Moz @julienw @flodolo