Fix Chrome support and add the field to send BiDi commands #32
Conversation
|
@juliandescottes would we need similar fixes for your client to get it connected to Chrome again? Or did we already land those? I cannot remember and didn't try out Chrome for a while. |
I've just checked the Julian's client with Chrome, and it seems to be working fine. |
src/components/BiDiLog.js
Outdated
| value={bidiCommand} | ||
| /> | ||
| {log.toReversed().map((entry) => ( | ||
| <BiDiLogEntry entry={entry} key={entry.message} /> |
There was a problem hiding this comment.
Not related to your change, but in my BiDi logs I had twice the message WebSocket closed and therefore they both had the same key. Because of this each re-render of the component leads to a react error, and since we re-render on every keystroke (due to the state update for inputChange), this makes the console logs hard to use.
There was a problem hiding this comment.
Right, I've added the index to the message, so it should make it more unique
Closes #11