Skip to content

fix(auth,apple): prevent EXC_BAD_ACCESS crash in Apple Sign-In completion handler #17273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2025
Merged

fix(auth,apple): prevent EXC_BAD_ACCESS crash in Apple Sign-In completion handler #17273

merged 1 commit into from
May 2, 2025

Conversation

lukemmtt
Copy link
Contributor

@lukemmtt lukemmtt commented Apr 12, 2025 •
edited
Loading

Fixes a crash where Firebase Auth's Apple Sign-In handler crashes with EXC_BAD_ACCESS on iOS/macOS when the completion handler is deallocated during async operations.

Specifically:

  • Captures appleCompletion locally within handleSignInWithApple to prevent deallocation
  • Adds nil check before calling the completion handler
  • Creates strong references for callbacks in async operations

Affects both iOS and macOS platforms through the shared implementation.

Closes #17216.

@google-cla Google CLA
Copy link

google-cla bot commented Apr 12, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@lukemmtt lukemmtt mentioned this pull request Apr 12, 2025
Closed
1 task
@lukemmtt
fix(auth,apple): prevent EXC_BAD_ACCESS crash in Apple Sign-In comple…
7ab5067 
…tion handler

- Locally captures completion handler to prevent deallocation
- Fixes crash during async Apple Sign-In operations
@lukemmtt lukemmtt force-pushed the apple-sign-in-fix branch from 673e3e5 to 7ab5067 Compare April 12, 2025 19:15
@lukemmtt lukemmtt marked this pull request as ready for review April 12, 2025 19:16
MichaelVerdon
MichaelVerdon approved these changes May 2, 2025
View reviewed changes
Copy link
Contributor

@MichaelVerdon MichaelVerdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this locally, seems to work fine. Thank you for this 😄

@Lyokone
Copy link
Contributor

Lyokone commented May 2, 2025

Thanks for the fix, really appreciate it :)

@Lyokone Lyokone merged commit cc7d28a into firebase:main May 2, 2025
36 of 44 checks passed
cynthiajoan added a commit that referenced this pull request May 8, 2025
@cynthiajoan @MichaelVerdon
@SelaseKay @Lyokone @lukemmtt @maneesht
chore(firebaseai): merge main into developer api branch (#17341)
4ad8731 
* chore(ci): bump macos-14 to macos-15 (#17311)

* feat(cloud_functions): add support for cloud functions stream (#17214)

* chore: add platform interface and method channel implementation for Cloud Functions stream

* chore: add `httpsCallableStreamFromUrl` and `httpsStreamCallableWithUri`

* chore: resolve comments

* chore: add Android implementation for Cloud Functions stream

* chore: resolve formatting issues

* chore: correct variable name

* chore: add support for Cloud Functions Stream(Android)

* chore: create dedicated StreamHandler class

* chore: add streamhandler implementation for ios

* chore: add iOS implementation for Cloud Functions stream

* chore: add license header to stream handler files

* chore: web Cloud Functions stream wip

* chore: push all

* chore: update functions based on API Doc modification

* chore: clean up code

* chore: add web package

* chore: add streaming example

* chore: fix ci issues

* chore: fix ci

* chore: fix cloud function test

* chore: add missing doc

* chore: fixes and  clean up

* chore: add e2e for Cloud Functions Stream

* chore: fix formatting issue

* chore: add more tests and fix timeout for Android

* chore: add test for map and list

* chore: fix test

* chore: update year to 2025 in files

* chore(web): add support for abort signal

* chore: resolve comments and add test for Abort

* chore: fix test

* chore: fix test

* chore: update copyright year

* chore: print error to console

* chore(release): publish packages (#17314)

* chore(release): publish packages

 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]+1

* chore: BoM Version 3.10.0

* constants

* fix(auth,apple): prevent EXC_BAD_ACCESS crash in Apple Sign-In completion handler (#17273)

- Locally captures completion handler to prevent deallocation
- Fixes crash during async Apple Sign-In operations

* chore(docs): Update Extension Helper Docs (#17327)

* feat(vertexai): Add HarmBlockThreshold.OFF (#17325)

* Add HarmBlockThreshold.OFF. Add unit test for api. Fix the schema output json.

* fix a nit

* feat(fdc): Included platform detection changes (#17308)

* feat(vertexai): Add responseModality (#17326)

* Add responseModality

* review comments

* handle omit tokenCount nicely (#17336)

* Add new attributes for schema (#17340)

* tweak after merge main

* fix analyzer for vertexai/api_test.dart

* remove dependency_overrides in pubspec.yaml

---------

Co-authored-by: MichaelV00 <[email protected]>
Co-authored-by: Jude Selase Kwashie <[email protected]>
Co-authored-by: Guillaume Bernos <[email protected]>
Co-authored-by: Luke Memet <[email protected]>
Co-authored-by: Maneesh Tewani <[email protected]>
cynthiajoan added a commit that referenced this pull request May 13, 2025
@cynthiajoan @natebosch
@MichaelVerdon @SelaseKay @Lyokone @lukemmtt @maneesht
feat(firebaseai): Developer API (#17342)
dbdd135 
* feat(vertexai): Allow serializing to Developer API models (#17294)

Move parsing from top level methods, and serialization from a method on
the model,into instance methods on a new `SerializationStrategy` class.
Use the existing parsing code for the vertex strategy and copy over code
form the developer SDK for the Google AI strategy.

Add a `_ModelUri` class to allow a vertex and developer specialization
for the different backends.

Copy the serialization and parsing tests from the developer SDK, skip a
few tests that rely on arguments or methods that are unsupported in the
vertex model. Tests skipped for content embedding and extra arguments
passed to countTokens.

* chore(vertexai): update sample for developer api and fix the instance key for FirebaseVertexAI  (#17319)

* add imagen developer api support (#17321)

* feat(vertexai): Add a new package firebase_ai (#17332)

* Add a new package firebase_ai

Copy all the code from firebase_vertexai and rename with "Vertex"
removed or replaced with "Firebase".

Make firebase_vertexai an export package, retaining only the
FirebaseVertexAI implementation and adding `typedef` aliases for 2
renamed exception types. Replace the rest with exports from
`package:firebase_ai`.

Revert the examples changes to use googleAI - the example in the
`firebase_ai` package will show both while the old example shows only
the usage of vertex..

Import from src across the packages to keep existing tests as close to
identical as possible despite doubling up test cases with the upstream
package.

* Move to new directory

* Add ::vertexai and ::googlai instance key suffixes

* Use ovrride and new SpeaechConfig API

* Remove export of TaskType

* Remove duplicate testing of the base model

* Use 2.0.0 as initial version

* Reformat

* Add a failing test - check if CI is already running

* Remove failing test

CI is confirmed running for this package.

* Add a copy of the analysis options in the new parent directory

* Revert to latest version of example app

Minor code changes for the interface change.

* Restore the same example app in both packages

Minor code changes in the _vertexai example app for the interface
differences

---------

Co-authored-by: Cynthia J <[email protected]>

* add all_link_rules.yaml to the root of new package

* chore(firebaseai): merge main into developer api branch (#17341)

* chore(ci): bump macos-14 to macos-15 (#17311)

* feat(cloud_functions): add support for cloud functions stream (#17214)

* chore: add platform interface and method channel implementation for Cloud Functions stream

* chore: add `httpsCallableStreamFromUrl` and `httpsStreamCallableWithUri`

* chore: resolve comments

* chore: add Android implementation for Cloud Functions stream

* chore: resolve formatting issues

* chore: correct variable name

* chore: add support for Cloud Functions Stream(Android)

* chore: create dedicated StreamHandler class

* chore: add streamhandler implementation for ios

* chore: add iOS implementation for Cloud Functions stream

* chore: add license header to stream handler files

* chore: web Cloud Functions stream wip

* chore: push all

* chore: update functions based on API Doc modification

* chore: clean up code

* chore: add web package

* chore: add streaming example

* chore: fix ci issues

* chore: fix ci

* chore: fix cloud function test

* chore: add missing doc

* chore: fixes and  clean up

* chore: add e2e for Cloud Functions Stream

* chore: fix formatting issue

* chore: add more tests and fix timeout for Android

* chore: add test for map and list

* chore: fix test

* chore: update year to 2025 in files

* chore(web): add support for abort signal

* chore: resolve comments and add test for Abort

* chore: fix test

* chore: fix test

* chore: update copyright year

* chore: print error to console

* chore(release): publish packages (#17314)

* chore(release): publish packages

 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]
 - [email protected]+1

* chore: BoM Version 3.10.0

* constants

* fix(auth,apple): prevent EXC_BAD_ACCESS crash in Apple Sign-In completion handler (#17273)

- Locally captures completion handler to prevent deallocation
- Fixes crash during async Apple Sign-In operations

* chore(docs): Update Extension Helper Docs (#17327)

* feat(vertexai): Add HarmBlockThreshold.OFF (#17325)

* Add HarmBlockThreshold.OFF. Add unit test for api. Fix the schema output json.

* fix a nit

* feat(fdc): Included platform detection changes (#17308)

* feat(vertexai): Add responseModality (#17326)

* Add responseModality

* review comments

* handle omit tokenCount nicely (#17336)

* Add new attributes for schema (#17340)

* tweak after merge main

* fix analyzer for vertexai/api_test.dart

* remove dependency_overrides in pubspec.yaml

---------

Co-authored-by: MichaelV00 <[email protected]>
Co-authored-by: Jude Selase Kwashie <[email protected]>
Co-authored-by: Guillaume Bernos <[email protected]>
Co-authored-by: Luke Memet <[email protected]>
Co-authored-by: Maneesh Tewani <[email protected]>

* manually update the schema_test with main code

* add the deprecation document (#17344)

* ignore deprecated_member_use for example in firebase_vertexai

* fix bidi web socket channel connect for chrome

* review comments

* readme words update

* try ignore the deprecation in the whole package analysis_options

---------

Co-authored-by: Nate Bosch <[email protected]>
Co-authored-by: MichaelV00 <[email protected]>
Co-authored-by: Jude Selase Kwashie <[email protected]>
Co-authored-by: Guillaume Bernos <[email protected]>
Co-authored-by: Luke Memet <[email protected]>
Co-authored-by: Maneesh Tewani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lyokone Lyokone Lyokone approved these changes

@MichaelVerdon MichaelVerdon MichaelVerdon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[firebase_auth]: handleSignInWithApple EXC_BAD_ACCESS (KERN_INVALID_ADDRESS)
3 participants
@lukemmtt @Lyokone @MichaelVerdon