Skip to content

fix(firestore): fix stream order when a transaction is running #10181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Dec 26, 2022

Description

Remove the queue to emit the event directly without waiting for other events (transaction event queued) that could interfere.
It matches how Android is handling the events (queue only for Transaction, not for snapshots stream)

Related Issues

closes #10153

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Lyokone Lyokone marked this pull request as draft December 27, 2022 07:36
@Lyokone Lyokone closed this Dec 29, 2022
@firebase firebase locked and limited conversation to collaborators Jan 29, 2023
@Lyokone Lyokone deleted the fix/10153_2 branch October 7, 2024 07:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [cloud_firestore] old data retrieved if get is called just after a transaction when a stream is active
1 participant