Skip to content

Update Bug Report Template #8434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 20, 2024
Merged

Update Bug Report Template #8434

merged 10 commits into from
Aug 20, 2024

Conversation

dlarocque
Copy link
Contributor

Our Bug report template required that the user input a browser version. This isn't applicable in cases where the bug occurs in a non-browser environment (e.g. Node, React Native).

Users usually only select one product. We should make it more clear that they can select multiple if they're relevant.

@dlarocque dlarocque requested a review from a team as a code owner August 16, 2024 18:43
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 16, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: fd7596e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 16, 2024 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/app

    TypeBase (f7c6dc4)Merge (8931d6f)Diff
    browser18.4 kB18.3 kB-97 B (-0.5%)
    esm524.1 kB24.0 kB-97 B (-0.4%)
    main25.2 kB25.1 kB-97 B (-0.4%)
    module18.4 kB18.3 kB-97 B (-0.5%)

  • @firebase/functions

    TypeBase (f7c6dc4)Merge (8931d6f)Diff
    browser9.72 kB9.76 kB+37 B (+0.4%)
    esm512.1 kB12.1 kB+37 B (+0.3%)
    main12.7 kB12.8 kB+37 B (+0.3%)
    module9.72 kB9.76 kB+37 B (+0.4%)

  • bundle

    46 size changes

    TypeBase (f7c6dc4)Merge (8931d6f)Diff
    analytics (logEvent)44.6 kB44.5 kB-93 B (-0.2%)
    app-check (CustomProvider)37.5 kB37.4 kB-93 B (-0.2%)
    app-check (ReCaptchaEnterpriseProvider)40.0 kB39.9 kB-93 B (-0.2%)
    app-check (ReCaptchaV3Provider)40.0 kB39.9 kB-93 B (-0.2%)
    auth (Anonymous)76.2 kB76.1 kB-93 B (-0.1%)
    auth (EmailAndPassword)84.5 kB84.4 kB-93 B (-0.1%)
    auth (GoogleFBTwitterGitHubPopup)103 kB103 kB-93 B (-0.1%)
    auth (GooglePopup)100 kB100 kB-93 B (-0.1%)
    auth (GoogleRedirect)100 kB100 kB-93 B (-0.1%)
    auth (Phone)86.8 kB86.8 kB-93 B (-0.1%)
    database (Append to a list of data)149 kB149 kB-93 B (-0.1%)
    database (Filtering data)148 kB148 kB-93 B (-0.1%)
    database (Listen for child events)165 kB164 kB-93 B (-0.1%)
    database (Listen for value events + Detach listeners)164 kB164 kB-93 B (-0.1%)
    database (Listen for value events)164 kB164 kB-93 B (-0.1%)
    database (Read data once)164 kB164 kB-93 B (-0.1%)
    database (Save data as transactions)166 kB166 kB-93 B (-0.1%)
    database (Sort data)150 kB150 kB-93 B (-0.1%)
    database (Write data)148 kB148 kB-93 B (-0.1%)
    firestore (CSI Auto Indexing Disable and Delete)270 kB270 kB-93 B (-0.0%)
    firestore (CSI Auto Indexing Enable)270 kB270 kB-93 B (-0.0%)
    firestore (Persistence)305 kB305 kB-93 B (-0.0%)
    firestore (Query Cursors)242 kB242 kB-93 B (-0.0%)
    firestore (Query)240 kB240 kB-93 B (-0.0%)
    firestore (Read data once)228 kB228 kB-93 B (-0.0%)
    firestore (Read Write w Persistence)325 kB325 kB-93 B (-0.0%)
    firestore (Realtime updates)230 kB230 kB-93 B (-0.0%)
    firestore (Transaction)207 kB207 kB-93 B (-0.0%)
    firestore (Write data)207 kB207 kB-93 B (-0.0%)
    firestore-lite (Query Cursors)91.3 kB91.3 kB-93 B (-0.1%)
    firestore-lite (Query)87.5 kB87.4 kB-93 B (-0.1%)
    firestore-lite (Read data once)63.0 kB62.9 kB-93 B (-0.1%)
    firestore-lite (Transaction)88.2 kB88.1 kB-93 B (-0.1%)
    firestore-lite (Write data)72.6 kB72.5 kB-93 B (-0.1%)
    functions (call)32.0 kB32.0 kB-60 B (-0.2%)
    messaging (send + receive)47.0 kB46.9 kB-93 B (-0.2%)
    performance (trace)51.8 kB51.8 kB-93 B (-0.2%)
    remote-config (getAndFetch)46.4 kB46.3 kB-93 B (-0.2%)
    storage (getBytes)42.2 kB42.1 kB-93 B (-0.2%)
    storage (getDownloadURL)44.2 kB44.1 kB-93 B (-0.2%)
    storage (getMetadata)43.7 kB43.6 kB-93 B (-0.2%)
    storage (list + listAll)43.1 kB43.0 kB-93 B (-0.2%)
    storage (updateMetadata)43.9 kB43.9 kB-93 B (-0.2%)
    storage (uploadBytes)48.8 kB48.7 kB-93 B (-0.2%)
    storage (uploadBytesResumable)58.8 kB58.7 kB-93 B (-0.2%)
    storage (uploadString)49.0 kB48.9 kB-93 B (-0.2%)

  • firebase

    TypeBase (f7c6dc4)Merge (8931d6f)Diff
    firebase-app-compat.js31.8 kB31.8 kB-94 B (-0.3%)
    firebase-app.js103 kB103 kB-125 B (-0.1%)
    firebase-compat.js788 kB788 kB-61 B (-0.0%)
    firebase-functions-compat.js8.19 kB8.22 kB+33 B (+0.4%)
    firebase-functions.js11.9 kB12.0 kB+33 B (+0.3%)
    firebase-performance-standalone-compat.es2017.js93.7 kB93.6 kB-93 B (-0.1%)
    firebase-performance-standalone-compat.js70.8 kB70.8 kB-91 B (-0.1%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/LnT0G84b6Q.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 16, 2024 •
edited
Loading

Size Analysis Report 1

This report is too large (151,124 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/R8hLjiPI8t.html

DellaBitta
DellaBitta requested changes Aug 16, 2024
View reviewed changes
@dlarocque dlarocque requested a review from DellaBitta August 16, 2024 19:35
hsubox76
hsubox76 reviewed Aug 19, 2024
View reviewed changes
hsubox76
hsubox76 reviewed Aug 19, 2024
View reviewed changes
hsubox76
hsubox76 reviewed Aug 19, 2024
View reviewed changes
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good, I added a couple of things now that you have started me thinking about it.

@github-actions GitHub Actions
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v3.0

@dlarocque dlarocque merged commit 1ff9661 into main Aug 20, 2024
23 checks passed
@dlarocque dlarocque deleted the dl/bug-template branch August 20, 2024 14:37
@firebase firebase locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DellaBitta DellaBitta DellaBitta approved these changes

@hsubox76 hsubox76 hsubox76 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dlarocque @google-oss-bot @DellaBitta @hsubox76