fix(app): fix issue with FirebaseApp extending INTERNAL #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FirebaseAppImpl should not extend prototype.INTERNAL as this will apply to all Firebase app instances. To reproduce, do the following: var app1 = firebase.initializeApp(config); var app2 = firebase.initializeApp(config, 'app2'); console.log(app1.INTERNAL === app2.internal); The above incorrectly resolves to true. This means that if I sign in with app1.auth() and then call app1.INTERNAL.getToken(), it will resolve with null as it is getting app2.INTERNAL.getToken. The last initialized instance will basically overwrite all existing ones. This is currently breaking all FirebaseUI-web single page applications using Firebase real-time database with JS version >= 4.1.0: firebase/firebaseui-web#47 (comment) This should also be breaking any application using Auth and Database with multiple app instances.
jshcrowthe
approved these changes
Jun 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FirebaseAppImpl should not extend prototype.INTERNAL as this will apply to
all Firebase app instances.
To reproduce, do the following:
The above incorrectly resolves to true.
This means that if I sign in with app1.auth() and then call app1.INTERNAL.getToken(),
it will resolve with null as it is getting app2.INTERNAL.getToken.
The last initialized instance will basically overwrite all existing ones.
This is currently breaking all FirebaseUI-web single page applications
using Firebase real-time database with JS version >= 4.1.0:
firebase/firebaseui-web#47 (comment)
This should also be breaking any application using Auth and Database with
multiple app instances.
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines: