Skip to content

Lower block limit, default depth=1 #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2023
Merged

Lower block limit, default depth=1 #288

merged 2 commits into from
Mar 20, 2023

Conversation

hannahhoward
Copy link
Contributor

Goals

Reduce Lassie over-fetching

Implementation

  • set a block limit of 10 for now
  • use only shallow recursion by default for now

guanzo
guanzo approved these changes Mar 20, 2023
View reviewed changes
Copy link
Collaborator

@guanzo guanzo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Something to consider from hannah:

"you CANNOT request more than 10 blocks period. even with depth=all."

@guanzo guanzo merged commit fdd0dcd into main Mar 20, 2023
@guanzo guanzo deleted the feat/lower-block-limit branch March 20, 2023 23:13
@lidel lidel mentioned this pull request Mar 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guanzo guanzo guanzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannahhoward @guanzo