feat: require LinkSystem argument for each retrieval #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
force-pushed
the
rvagg/blockstore-per-request
branch
2 times, most recently
from
8a6051e to
cf58cb1
Compare
Allows for separate, or combined block storage for each retrieval Closes: #33
rvagg
force-pushed
the
rvagg/blockstore-per-request
branch
from
cf58cb1 to
5c7f66f
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
==========================================
+ Coverage 52.05% 52.71% +0.65%
==========================================
Files 19 19
Lines 1944 1990 +46
==========================================
+ Hits 1012 1049 +37
- Misses 898 907 +9
Partials 34 34
|
|
updated to go-data-transfer 2.0.0-rc2 and marked ready for review |
hannahhoward
approved these changes
Jan 31, 2023
|
fyi @kylehuntsman to be aware of for #52 |
kylehuntsman
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for separate, or combined block storage for each retrieval.
Uses filecoin-project/go-data-transfer#362, will be draft until that's merged.