This repository was archived by the owner on Mar 15, 2024. It is now read-only.
Fix bugs in event validation and make criteria stronger #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bugs where: * empty events in batch were considered valid * cid was not checked for validity * peer ID was not checked for validity * time span of start and event time was unchecked. Refactor codes to instead check the zero valued struct for validity, as we need to do that anyway. Using pointers doesn't make sense here because all the pointer fields are required to have valid content and we do not need to infer whether they were actually present in JSON or not. Add extra tests to cover more edge cases
masih
force-pushed
the
masih/event_validation_fix_bugs
branch
from
8dbacf2 to
ea9409f
Compare
willscott
approved these changes
Mar 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bugs where:
Refactor codes to instead check the zero valued struct for validity, as we need to do that anyway. Using pointers doesn't make sense here because all the pointer fields are required to have valid content and we do not need to infer whether they were actually present in JSON or not.
Add extra tests to cover more edge cases