This repository was archived by the owner on Mar 15, 2024. It is now read-only.
Add tracking of graphsync failures #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willscott
approved these changes
Mar 28, 2023
davidd8
reviewed
Mar 28, 2023
| @@ -28,7 +28,9 @@ func (m *Metrics) HandleFailureEvent(ctx context.Context, id types.RetrievalID, | |||
| _ = m.tempDataMap.Delete(id) | |||
| m.requestWithIndexerFailures.Add(ctx, 1) | |||
| case types.RetrievalPhase: | |||
|
|
|||
| if storageProviderID != types.BitswapIndentifier { | |||
There was a problem hiding this comment.
why not use the protocol() helper function here?
There was a problem hiding this comment.
protocol is a bit different. it does the string conversion to "graphsync" versus "bitswap"? I guess it doesn't matter.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Determine how often initiated graphsync requests are actually failing, versus just getting cancelled..
Implementation
For discussion
The failure here is a bit divergent with how we count things elsewhere. Most of our other metrics are "0 or 1 per request" -- i.e. across the entire request, it either happened or didn't happen. However you can get multiple failures with SPs. While we can record failures on a per request basis, I think it's more informative in terms of "are SPs succeeding" to count each failed attempt individually.