Improve column manager handling with hidden closures #17040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danharrin
approved these changes
Jul 21, 2025
|
Thanks! |
danharrin
deleted the
Improve-columnManager-handling-with-hidden-closures
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the outstanding issue from #16943 where a column is hidden based on the activeTab AND the table columns have been reordered. This is done by reverting some of the changes in the previous PR and instead of removing the column if it's hidden, it is instead filtered out in blade/js.
It also improves the default syncing of the
isToggledHiddenByDefault()in that if a column is initially created and is NOTtoggleable(), but then->toggleable(isToggledHiddenByDefault: true)is subsequently added by the dev, the column will be correctly toggled off on the next refresh. Note, once a column istoggleable(), changing the boolean value ofisToggledHiddenByDefaultwill NOT update the column's state in the UI as this would potentially override any toggling the user has done. Of course, resetting the column manager will set the column to whatever this default is.composer cscommand.