feat(install-script): pin aws-iam-authenticator version to v0.6.14 #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will hard code the version of aws-iam-authenticator binary within the install-kconnect script until the issue with the aws-iam-authenticator GitHub repo is fixed. It looks like the latest release of aws-iam-authenticator failed to be release properly, and waiting for one of the maintainers to fix the release. kubernetes-sigs/aws-iam-authenticator#720 Signed-off-by: Casale, Robert <[email protected]>
Gearheads
requested review from
rajarajanpsj,
kishoregv,
niroowns,
awatterson22,
felixdeleon and
gseshagirirao
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This change will hard code the version of
aws-iam-authenticatorbinary within theinstall-kconnectscript until the issue with theaws-iam-authenticatorGitHub repo is fixed. It looks like the latest release ofaws-iam-authenticatorfailed to be release properly, and waiting for one of the maintainers to fix the release.Testing
Manually ran the curl command, and can confirm that the version is being returned as expected:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes # Users have reported having issues with downloading the latest version of the
aws-iam-authenticator. This should now allow users to download versionv0.6.14of theaws-iam-authenticator.This branch can be deleted once it is merged.