Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Browser IDP & Browser MFA support using saml2aws/v2 #650

Merged
merged 2 commits into from
Apr 26, 2024
Merged

fix: Browser IDP & Browser MFA support using saml2aws/v2 #650

merged 2 commits into from
Apr 26, 2024

Conversation

0rax
Copy link
Contributor

@0rax 0rax commented Mar 27, 2024

What this PR does / why we need it:

This also allows users to use more complex 2FA methods, as well as adding support for browser IDPs. This is based on the work done in PR #350 which has been pretty stale.

Reading through the original PR and with Versent/saml2aws#794 being merged, the need for a fork of saml2aws is no longer needed. I thus also updated the dependency to saml2aws to the current latest version (using go mod), allowing the submodule to be removed.

I also updated the logic in pkg/plugins/identity/saml/sp/aws/resolver.go to use the ProviderList already available in saml2aws so updating the dependency should also update the list of idp-provider supported.

In the end, I needed the dependency to be updated to be able to use g.co/sc as my 2FA provider in kconnect which works flawlessly in saml2aws.

image

The config used to test it is:

apiVersion: kconnect.fidelity.github.com/v1alpha1
kind: Configuration
spec:
  providers:
    eks:
      region: eu-west-3
      idp-protocol: saml
      idp-provider: GoogleApps
      idp-endpoint: https://accounts.google.com/o/saml2/initsso?idpid=XXXXXXXXX&spid=XXXXXXXXXXXX&forceauthn=false

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #349

Copy link
Collaborator

@Gearheads Gearheads left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. make ci completed successfully, and I was able to connect to a Kubernetes cluster.

@Gearheads Gearheads merged commit 88f58b2 into fidelity:main Apr 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for browser based IDP providers
2 participants