Skip to content

franz-custom-website: fix click events when trapLinkClicks is enabled #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

s-ol
Copy link

@s-ol s-ol commented Jan 26, 2025

Pre-flight Checklist

Please ensure you've completed all of the following.

Description of Change

Fully deactivates messing with click events when "Open external URLs in Ferdium" is enabled. Previously Ferdium would eat all click events on <a href="http://... and <button title="http://... tags, breaking sites that override click events to provide in-page navigation.

Close ferdium/ferdium-app#2028

@Alphrag
Copy link
Member

Alphrag commented Apr 18, 2025

Hi @s-ol, the use case you are mentioning should not warrant for a complete suppression of this feature, however we would be happy to see the code improved. The problem described in the issue linked is about the question of whether the event should be stopped from propagating or not. Indeed, on some websites if this event is not stopped when trapLink is on, then the webpage will open in the browser anyway, which goes against what the goal of trapLink was in the first place.
So if there is a way to control than when this were to happen we block the event from happening, and we let it be if it is instead helping to move in the page, then that would be a perfect change. At the current status, we do not want to merge such a change that simply disable it entirely.

@Alphrag Alphrag added invalid This doesn't seem right question ❓ Further information is requested labels Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right question ❓ Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Website Service breaks JS click events on <a> tags
2 participants