Test to verify hooks get chained

[daffl]

Also adds an error when you try to register an unknown hook type.

[eddyystop]

Run

const feathers = require('feathers');
const hooks = require('feathers-hooks');

const app = feathers()
  .configure(hooks())
  .configure(services);

function services() {
  this.use('/messages', {
    create(data, params) {
      console.log('create. throw', data.throw);
      return data.throw ? Promise.reject(new Error('x')) : Promise.resolve();
    },
  });

  const messages = this.service('messages');

  messages.hooks({
    before: {
      all: () => { console.log('#1 before all'); },
      create: () => { console.log('#1 before create'); },
    },
    after: {
      all: () => { console.log('#1 after all'); },
      create: () => { console.log('#1 after create'); },
    },
    error: {
      all: () => { console.log('#1 error all'); },
    }

  });

  messages.before({
    all: () => { console.log('#1a before all'); },
  });
}

const messages = app.service('messages');

messages.after({
  before: {
    all: () => { console.log('#2 before all'); },
    create: () => { console.log('#2 before create'); },
  },
  after: {
    all: () => { console.log('#2 after all'); },
    create: () => { console.log('#2 after create'); },
  },
  error: {
    all: () => { console.log('#2 error all'); },
  }
});

messages.before({
  all: () => { console.log('#3 before all'); },
  create: () => { console.log('#3 before create'); },
});
messages.after({
  all: () => { console.log('#3 after all'); },
  create: () => { console.log('#3 after create'); },
});

messages.create({ throw: false });

setTimeout(() => {
  console.log('=====');
  messages.create({ throw: true });
}, 100);

and you will see

#1 before all
#1 before create
#1a before all
#3 before all
#3 before create
create. throw false
#1 after all
#1 after create
#3 after all
#3 after create
=====
#1 before all
#1 before create
#1a before all
#3 before all
#3 before create
create. throw true
#1 error all

The hooks logging #2 are not run. Maybe I'm being blind, but I think they should be run.

[daffl]

As we found out in our Slack discussion, the #2 hooks have to be registered via

messages.hooks({
  before: {
    all: () => { console.log('#2 before all'); },
    create: () => { console.log('#2 before create'); },
  },
  after: {
    all: () => { console.log('#2 after all'); },
    create: () => { console.log('#2 after create'); },
  },
  error: {
    all: () => { console.log('#2 error all'); },
  }
});